-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding jax.numpy.histogram #21958
Adding jax.numpy.histogram #21958
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your function seems to be failing for the following, I have provided the falsifying example below:
E AssertionError: The length of results from backend numpy and ground truth framework jax does not match
E
E len(ret_np_flat) != len(ret_np_from_gt_flat):
E
E ret_np_flat:
E
E [array([0.], dtype=float32)]
E
E ret_np_from_gt_flat:
E
E [array([0.], dtype=float32), array([0., 1.], dtype=float32)]
E Falsifying example: test_jax_histogram(
E on_device='cpu',
E frontend='jax',
E backend_fw='numpy',
E values=(array([-1., -1.], dtype=float32),
E array([0., 1.], dtype=float32),
E 0,
E True,
E False,
E 'float32',
E None,
E array([-1., -1.], dtype=float32),
E False,
E 'float32'),
E test_flags=FrontendFunctionTestFlags(
E num_positional_args=0,
E with_out=False,
E inplace=False,
E as_variable=[False],
E native_arrays=[False],
E generate_frontend_arrays=False,
E ),
E fn_tree='ivy.functional.frontends.jax.numpy.histogram',
E )
E
E You can reproduce this example by temporarily adding @reproduce_failure('6.82.4', b'AXicY2BgZMAOGKESMHlGItkwAAACQQAM') as a decorator on your test case
Kinldy look into this, thanks! 🙂
range=None, | ||
weights=None, | ||
density=False, | ||
) -> ivy.Array: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to add a typehint here.
Closing due to inactivity |
Close #19652
the requested changes as #21188 are done